Fix physical bone update without simulating #96270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
added
bug
topic:physics
regression
topic:animation
topic:3d
cherrypick:4.3
fire
approved these changes
Sep 3, 2024
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used old flags that are no longer functional by mistake, so correct it.
The physics calculation glitches when PhysicalBoneSimulator's influence is 0.001~0.999, but this is probably due to the fact that the position set by PhysicalBone moves outside of the physics calculation due to SkeletonModifier interpolation which breaks the physics calculation, so it may be necessary to rework the PhysicalBone calculation later. For now, this PR aims to remove Regression when the influence is 1.0.